fix: handle wheels without hash digests from private registries#793
Open
roundhd wants to merge 1 commit intoaspect-build:mainfrom
Open
fix: handle wheels without hash digests from private registries#793roundhd wants to merge 1 commit intoaspect-build:mainfrom
roundhd wants to merge 1 commit intoaspect-build:mainfrom
Conversation
Private PyPI registries (e.g., Azure Artifacts, Artifactory) may not serve PEP 503 hash fragments in download URLs. This causes KeyError when `_whl_repo_name` and `_raw_whl_repos` unconditionally access `whl["hash"]`. Fall back to `sha1(whl["url"])[:8]` for repo naming and empty string for shasum when hash is missing. Fixes aspect-build#790
|
Shiyuan Zheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Collaborator
|
Good find, will have to cherry pick this into the reworked extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Private PyPI registries (e.g., Azure Artifacts, Artifactory) may not serve PEP 503 hash fragments in download URLs. The uv extension unconditionally accesses
whl["hash"]in_whl_repo_nameand_raw_whl_repos, causing a KeyError.Changes:
_whl_repo_name: Fall back tosha1(whl["url"])[:8]when"hash"key is missing_raw_whl_repos: Use empty string forshasumwhen"hash"key is missingFixes #790